Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bokeh from 2 to 3 #94

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Bump bokeh from 2 to 3 #94

merged 3 commits into from
Oct 4, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 2, 2023

Bump Bokeh from 2 to 3, as well as related visualization packages.

See changelog at https://docs.bokeh.org/en/3.2.2/docs/releases.html#release-3-2-2

Addresses #86.

@weiji14 weiji14 self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Binder 👈 Test this PR on Binder

@weiji14 weiji14 mentioned this pull request Sep 28, 2023
9 tasks
@weiji14
Copy link
Member Author

weiji14 commented Oct 2, 2023

/condalock

- cartopy~=0.21.1 # geospatial plotting with matplotlib
- geoviews==1.9.5
- hvplot==0.8.2
- geoviews~=1.10.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested the interactive visualization with the binder link https://mybinder.org/v2/gh/CryoInTheCloud/hub-image/bokeh-3. Using the first example from https://geoviews.org

import geoviews as gv
import geoviews.feature as gf
import xarray as xr
from cartopy import crs

gv.extension("bokeh")

# %%
(gf.ocean + gf.land + gf.ocean * gf.land * gf.coastline * gf.borders).opts(
    'Feature', projection=crs.Geostationary(), global_extent=True, height=325).cols(3)

produces

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone has ideas on how we add a test to ensure the interactive visualization doesn't break in future Bokeh/Holoviews/Hvplot/Geoviews updates, I'm all ears!

@weiji14 weiji14 marked this pull request as ready for review October 3, 2023 23:11
@weiji14 weiji14 requested review from tsnow03 and MattF-NSIDC October 4, 2023 20:25
Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Haven't used geoviews before but I clearly need to try it :)

@weiji14 weiji14 merged commit b25e785 into main Oct 4, 2023
1 check passed
@weiji14 weiji14 deleted the bokeh-3 branch October 4, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants