Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-mode #90

Merged
merged 2 commits into from
Sep 22, 2023
+1 −2
Merged

Remove python-mode #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e081d
Remove python-mode
weiji14 Sep 20, 2023
b356384
Increase conda-lock timeout from 15 to 30min
weiji14 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/conda-lock-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
permissions:
contents: write # for Git to git push
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-lock keeps timing out, so have increased this from 15 to 30min.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about running conda-lock with the mamba solver (--mamba)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we're running it with mamba already

hub-image/.github/workflows/conda-lock-command.yml

Line 52 in 0cb0ff7

conda-lock lock --mamba --kind explicit --file environment.yml --platform linux-64

So not sure why the solver is still taking that long. It only takes 35s on my laptop 😅

Copy link
Member Author

@weiji14 weiji14 Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we pass the --mamba flag, but I'm not sure if mamba is actually installed 😳. Should take a look.

Edit: Opened PR at #91

defaults:
run:
shell: bash -l {0}
Expand Down
1 change: 0 additions & 1 deletion apt.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ wget
vim
emacs-nox
emacs-goodies-el
python-mode

# A couple of CLI editors that are easier than vim
# micro # currently not working on 18.04
Expand Down