Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xarray and friends #113

Merged
merged 4 commits into from
May 20, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ dependencies:

# Core scientific python stack
- cython==0.29.32 # optimization, C API access
- flox~=0.9.7 # optimization, xarray operations
- hypothesis==6.58.0 # needed by numpy testing tools
- networkx==2.8.8
- numba~=0.58.1 # high-performance numerics
Expand All @@ -62,7 +63,7 @@ dependencies:
- scipy==1.9.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not solve for environment specs
The following packages are incompatible
├─ scipy 1.9.3  is requested and can be installed;
└─ xarray >=2024.05.0  is not installable because it requires
   └─ scipy >=1.10 , which conflicts with any installable versions previously reported.

Situations like these make me question the pinning strategy here, wouldn't it be better to unpin everything and just use the lockfile to keep track of exact versions over time?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we were slowly trying to move towards >= or ~= pinning per #46, but could revisit the topic. I do think that conda-lock has matured quite a bit now, and we could consider just unpinning everything and rely on the unified lockfile (once I get the time to update #14).

- statsmodels==0.13.5
- sympy~=1.12
- xarray>=2023.05.0
- xarray>=2024.05.0

# Visualization packages
- bokeh~=3.2.2
Expand All @@ -80,15 +81,16 @@ dependencies:
- geopandas~=0.13.2
- pygmt~=0.10.0
- rasterio~=1.3
- rioxarray~=0.14.1
- xarray-datatree~=0.0.12
- rioxarray~=0.15.5
- xarray-datatree~=0.0.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know whether the migration of datatree into xarray is good enough yet to just drop xarray-datatree? I saw in the changelog at https://github.com/pydata/xarray/releases/tag/v2024.05.0 which said that most of the code has been migrated, but not sure how feature complete things are.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true! time to drop it here


# File formats and file management, download, dataset caching
- h5py~=3.8
- hdf5~=1.14
- h5netcdf==1.1.0
- h5netcdf~=1.3.0
- nco~=5.1.6
- pooch==1.6.0
- zarr~=2.18

# Cloud access tools and libraries
- awscli~=1.27.76
Expand Down
Loading