Update xarray and friends #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/condalock |
|
|
weiji14
reviewed
May 16, 2024
environment.yml
Outdated
Comment on lines
84
to
85
| - rioxarray~=0.15.5 | ||
| - xarray-datatree~=0.0.14 |
There was a problem hiding this comment.
Do you know whether the migration of datatree into xarray is good enough yet to just drop xarray-datatree? I saw in the changelog at https://github.com/pydata/xarray/releases/tag/v2024.05.0 which said that most of the code has been migrated, but not sure how feature complete things are.
There was a problem hiding this comment.
true! time to drop it here
|
/condalock |
scottyhq
commented
May 17, 2024
environment.yml
Outdated
| @@ -62,7 +63,7 @@ dependencies: | |||
| - scipy==1.9.3 | |||
There was a problem hiding this comment.
Could not solve for environment specs
The following packages are incompatible
├─ scipy 1.9.3 is requested and can be installed;
└─ xarray >=2024.05.0 is not installable because it requires
└─ scipy >=1.10 , which conflicts with any installable versions previously reported.
Situations like these make me question the pinning strategy here, wouldn't it be better to unpin everything and just use the lockfile to keep track of exact versions over time?
There was a problem hiding this comment.
|
/condalock |
weiji14
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There a many great new xarray features from the last year. This bumps to the latest version as well as optional dependencies