Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ATL15 tutorial with icepyx updates #90

Merged
merged 9 commits into from
Oct 11, 2024
Merged

Updating ATL15 tutorial with icepyx updates #90

merged 9 commits into from
Oct 11, 2024

Conversation

tsnow03
Copy link
Member

@tsnow03 tsnow03 commented Apr 5, 2024

No description provided.

Copy link

github-actions bot commented Apr 5, 2024

Binder 👈 Launch a binder notebook on this branch

@JessicaS11
Copy link
Contributor

This PR is a follow up on #89, which needed to be merged before the ATL15 tutorial was completely updated because the corresponding icepyx PR is still awaiting review (any volunteers?)

@wsauthoff wsauthoff closed this Sep 16, 2024
@wsauthoff wsauthoff deleted the ALT15 branch September 16, 2024 22:30
@JessicaS11 JessicaS11 restored the ALT15 branch September 18, 2024 13:32
@JessicaS11
Copy link
Contributor

Hey @wsauthoff - not sure why this branch was closed but it's still active. I actually was planning to complete it a couple weeks ago when I learned that geopandas has moved their underlying map layers to an external library, which no longer includes the countries layer because it indicates political boundaries. As a result, the sections of the tutorial using the "Greenland" polygon no longer work (I believe they were part of the notebook you developed originally), so I was unable to update the icepyx-related outputs and merge this PR.

@JessicaS11 JessicaS11 reopened this Sep 18, 2024
Copy link

Binder 👈 Launch a binder notebook on this branch

@wsauthoff
Copy link
Member

wsauthoff commented Sep 18, 2024

Hey @wsauthoff - not sure why this branch was closed but it's still active. I actually was planning to complete it a couple weeks ago when I learned that geopandas has moved their underlying map layers to an external library, which no longer includes the countries layer because it indicates political boundaries. As a result, the sections of the tutorial using the "Greenland" polygon no longer work (I believe they were part of the notebook you developed originally), so I was unable to update the icepyx-related outputs and merge this PR.

Hi @JessicaS11, I didn't realize it was still active. I was trying clean up my local and remote branches. Major apologies! PS...Congrats on your AGU24 Open Science award!

@wsauthoff
Copy link
Member

Hi @JessicaS11, I made changes to the ATL15 lakes tutorial notebook that fixes the deprecated geopandas code in this PR. I'm just having an issue with GitHub indicating there are conflicts in the feature branch within that tutorial notebook that I haven't been able to figure out just yet.

@JessicaS11
Copy link
Contributor

JessicaS11 commented Sep 19, 2024

I made changes to the ATL15 lakes tutorial notebook that fixes the deprecated geopandas code in this #109.

Can you share how this new notebook is meant to interface with the existing one? On a first quick read-through it appears to have a lot of similar content to the existing notebook. I'll also note it doesn't appear to have been added to the TOC.

I'm just having an issue with GitHub indicating there are conflicts in the feature branch within that tutorial notebook that I haven't been able to figure out just yet.

It looks like there are still conflicts. I'll see if I can figure them out.

@JessicaS11
Copy link
Contributor

@wsauthoff I got all the conflicts resolved and it's looking great. Somehow all the changes meant that the GitHub history of the branch was suddenly very different from my local copy, which didn't help!

I'd like to recommend that we move the non-ATL15 content (so the earthaccess data access) to a different notebook. It aligns nicely with some content the CryoCloud book already has on accessing NASA data (so perhaps should be integrated into those tutorials or put adjacent to them?), but feels very off topic to include in this one.

@JessicaS11
Copy link
Contributor

I'm apparently also not able to render the notebook outputs - all the figure cells result in a: Error displaying widget: model not found. Do I need to install something to my local hub?

@JessicaS11
Copy link
Contributor

@wsauthoff I created a copy of this tutorial (earthaccess-stream.ipynb) that still contains the earthaccess streaming section and put it in the "earthaccess-stream" branch so you can easily find the content if you want to integrate it into another section. Then I removed that content from this ATL15 tutorial. I would still be curious how this tutorial is meant to align with the other ATL15 one, as I think it will be confusing for users to have two that are so similar.

@JessicaS11 JessicaS11 merged commit 0af52d7 into main Oct 11, 2024
4 checks passed
@JessicaS11 JessicaS11 deleted the ALT15 branch October 11, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants