-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ATL15 tutorial with icepyx updates #90
Conversation
This PR is a follow up on #89, which needed to be merged before the ATL15 tutorial was completely updated because the corresponding icepyx PR is still awaiting review (any volunteers?) |
Hey @wsauthoff - not sure why this branch was closed but it's still active. I actually was planning to complete it a couple weeks ago when I learned that geopandas has moved their underlying map layers to an external library, which no longer includes the countries layer because it indicates political boundaries. As a result, the sections of the tutorial using the "Greenland" polygon no longer work (I believe they were part of the notebook you developed originally), so I was unable to update the icepyx-related outputs and merge this PR. |
Hi @JessicaS11, I didn't realize it was still active. I was trying clean up my local and remote branches. Major apologies! PS...Congrats on your AGU24 Open Science award! |
Hi @JessicaS11, I made changes to the ATL15 lakes tutorial notebook that fixes the deprecated geopandas code in this PR. I'm just having an issue with GitHub indicating there are conflicts in the feature branch within that tutorial notebook that I haven't been able to figure out just yet. |
Can you share how this new notebook is meant to interface with the existing one? On a first quick read-through it appears to have a lot of similar content to the existing notebook. I'll also note it doesn't appear to have been added to the TOC.
It looks like there are still conflicts. I'll see if I can figure them out. |
@wsauthoff I got all the conflicts resolved and it's looking great. Somehow all the changes meant that the GitHub history of the branch was suddenly very different from my local copy, which didn't help! I'd like to recommend that we move the non-ATL15 content (so the earthaccess data access) to a different notebook. It aligns nicely with some content the CryoCloud book already has on accessing NASA data (so perhaps should be integrated into those tutorials or put adjacent to them?), but feels very off topic to include in this one. |
I'm apparently also not able to render the notebook outputs - all the figure cells result in a: |
@wsauthoff I created a copy of this tutorial ( |
No description provided.