Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Framework Bug causes failed asset loading in JetMenu #831

Closed
jasonhuntrods-toast opened this issue Jan 19, 2020 · 1 comment
Closed
Assignees

Comments

@jasonhuntrods-toast
Copy link

JetMenu uses the Cherry Framework which currently has a bug and is not maintained anymore.

This is the issue:
CherryFramework/cherry-framework#178

This is the fix:
CherryFramework/cherry-framework#181

Using a fork of Cherry Framework with that PR would fix the problem, the bug specifically is that JetMenu loads assets from the wrong directory at times, depending on your Wordpress configuration. The result is cherry-js-core.js and cherry-handler.js 404. A simple way to reproduce would be to just install JetMenu in production on a site and check the JS console when loading. The primary difference in the wrong asset path is that "www" is appended to the beginning when it shouldn't be.

@jasonhuntrods-toast jasonhuntrods-toast changed the title CherryCore Bug causes failed asset loading in JetMenu Cherry Framework Bug causes failed asset loading in JetMenu Jan 19, 2020
@ZemezLab
Copy link

Cherry Framework 5 was successfully deleted (v1.6.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants