Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JetCompareWishlist : "cx_include_module_url" is missing from loader.php #1066

Closed
benjaminhaeberli opened this issue Apr 2, 2020 · 1 comment

Comments

@benjaminhaeberli
Copy link

Describe the bug
We use Bedrock (from Roots) as boilerplate for our Wordpress websites and we can't use JetCompareWishlist because the URL generated in loader.php is not correct. I contacted your technical suppord and they sent me the jet-fix-framework-url to avoid this error. It did not work and I found that in the loader.php of JetCompareWishlist, the cx_include_module_url filter is missing (only for this plugins, the others are OK).

To Reproduce
Steps to reproduce the behavior:

  1. Activate JetCompareWishlist without any other Jet plugin
  2. Use Bedrock

Expected behavior
I think you need to add the cx_include_module_url filter in the loader.php as the other plugins 👍

if (file_exists($path)) {
    $dir = pathinfo($path, PATHINFO_DIRNAME);

    $url = str_replace(
    '\\',
    '/',
    str_replace(untrailingslashit(ABSPATH), esc_url(site_url()), $dir)
);

    $this->included_modules[ $slug ] = array(
    'path' => trailingslashit($dir),
    'url'  => apply_filters('cx_include_module_url', trailingslashit($url), $path),
);

    require_once $path;
}

Screenshots
Wordpress back-office (plugin settings)
GitHub Logo

Additional context
This issue seems to be related with the #831 and #833

@kaskad88
Copy link
Collaborator

kaskad88 commented Apr 2, 2020

JetCompareWishlist v1.1.1 has been released.
Feel free to update!

@kaskad88 kaskad88 closed this as completed Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants