Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wild bug -- test fix #28

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Wild bug -- test fix #28

merged 1 commit into from
Mar 11, 2024

Conversation

scosman
Copy link
Contributor

@scosman scosman commented Mar 11, 2024

  • Compiled CSR js uses a hash of the page as name
  • DNS based ad blockers (NextDNS) detect that as ad uri, block it

Changing content, should change hash. Testing on branch before merge.

@scosman
Wild bug.
a985a79 
 - Compiled CSR js uses a hash of the page as name
 - DNS based ad blockers (NextDNS) detect that as ad uri, block it

Changing content, should change hash. Testing on branch before merge.
@scosman
Copy link
Contributor Author

scosman commented Mar 11, 2024

Confirmed changed the CSR js name. Confirmed working in staging env. Will see if this works in prod.

Only impacts NextDNS users, so not critical, and not our bug (failing to load page when resource blocked is unavoidable). But still, want to fix it since I use NextDNS!

@scosman scosman merged commit 1188aae into main Mar 11, 2024
7 checks passed
@scosman scosman deleted the blog_uri_fix branch March 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@scosman