-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Text Clipping of Descenders in bg-clip-text by Adjusting Padding and Margins #148
Conversation
…nders Adds a small padding at the bottom to prevent lack of space for descenders, leading to descenders like "g" and "p" being cut off at the bottom. (Caused by bg-clip-text and text-transparent.)
…ders Adds a small padding at the bottom to prevent lack of space for descenders, leading to descenders like "g" and "p" being cut off at the bottom. (Caused by bg-clip-text and text-transparent.)
Adjust the bottom margin or the top margin of the next element to balance the extra space created by pb
WalkthroughThe changes involve updates to the styling of text elements in the hero and feature exploration sections of the marketing page. Adjustments include modifications to margin and padding properties, enhancing the visual layout without affecting the functionality of the page. Changes
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Good catch! An amazing lack of descenders (except "p") on the demo page. Thanks |
Combining
bg-clip-text
withtext-transparent
can cause descenders (e.g., in characters like "p" and "g") to be clipped. This fix adds padding to ensure descenders are not cut off and adjusts margins to maintain consistent spacing between elements. The changes ensure that the text rendering remains visually intact without affecting the layout's overall appearance.Summary by CodeRabbit