Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to budhud customizations #251

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

szero
Copy link
Contributor

@szero szero commented Oct 6, 2024

Hello, so I've added inputs boxes to adjust engineer's build menu position, option to put metal counter under crosshair and speedometer section under general ui. I run the file through my default formater so there is bit more changes than that.

@CriticalFlaw
Copy link
Owner

CriticalFlaw commented Oct 6, 2024

Looks good - I ran it through some tests and everything worked as expected.

I've corrected the formatting and also converted the building status positions to use a number picker instead of a textbox. Reason being that the textbox does not limit user input to numbers only and it caused issues when I tested it by entering gibberish.

While testing I've noticed that manually entering numbers was disabled so it has been re-enabled and now whatever the user enters will be auto-corrected to be a number in the 0-1000 range.

Please give it a quick look over and if there aren't any concerns, I'll merge it in. Thanks!

@szero
Copy link
Contributor Author

szero commented Oct 7, 2024

Yep, I've used the number picker at first but didn't like it because you couldn't input numbers by hand but its better like this if it can be enabled back, also making it fit into 2 spaces instead of 1 makes it more readable. LGTM

@CriticalFlaw CriticalFlaw reopened this Oct 7, 2024
@CriticalFlaw CriticalFlaw merged commit 4782501 into CriticalFlaw:master Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants