New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Support for `{id:"", src:""}` Format... #318

Open

probityrules wants to merge 1 commit into CreateJS:2.0 from gopherwood:bugfix/byhash

probityrules commented Jul 26, 2019

This fixes a few issues with the {src: "path/to/file", id: "audioId"} format for both sound registration and sound removal:

registerSounds passes the id to registerSound for each entry if it's defined.
Registration accepts src property in a hash.
Registration correctly accepts file-types in hash (parameter/variable name mismatch).
Sound removal accepts {id: "audioId"} format to mirror sound registration, like SoundJS v1.
Put in a rejection analogous to _fetchByUrlArray for _fetchByUrlHash since it appeared to be missing.


          This fixes a few issues with the `{src: "path/to/file", id: "audioId"…

723775c

…}` format for both sound registration and sound removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet