Edit README File #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmthorsnes
reviewed
Mar 15, 2018
kmthorsnes
reviewed
Mar 15, 2018
README.md
Outdated
| @@ -89,26 +87,26 @@ Give an example | |||
|
|
|||
| ## Deployment | |||
|
|
|||
| Add additional notes about how to deploy this on a live system | |||
|
|
|||
| Visit (https://papnews.herokuapp.com/) for deployed app | |||
There was a problem hiding this comment.
I would keep it, but format it differently in Markdown
Visit [the deployed app](https://papnews.herokuapp.com/).
kmthorsnes
reviewed
Mar 15, 2018
README.md
Outdated
|
|
||
| Welcome to Pap News - _Spread the knowledge!_ | ||
|
|
||
| ## Description | ||
| Week 8 Project of Craft Academy cohort January 2018. | ||
|
|
||
| PapsNews is a newsagency Web Application used to share your local and international news directly on your device screen. | ||
| PapsNews is a News Agency Web Application used to share your local and international news directly on your device screen. | ||
|
|
||
| Once you land on the Homepage (https://....herokuapp.com/), you need to Signup in order to have access to the web contents |
There was a problem hiding this comment.
remove ( ) and add hyperlink?
|
Please use capitalized titles on PR´s. I'd love to hear more about the agile way of editing readme's |
add .env to gitignore
davidboll
approved these changes
Mar 19, 2018
|
14hours later and 3 approvals, still not merged 🤔 |
|
Please merge or close this one. Don't keep PR's around for so long. Changes to README can be done continuously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT Story: https://www.pivotaltracker.com/story/show/155981938
Description
Changes proposed in this pull request:
What I have learned working on this feature: