Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Retry code to its own method for Hooking purposes #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Viv-0
Copy link

@Viv-0 Viv-0 commented Oct 18, 2021

This pull request just moves the code that makes the Player retry to its own method.
I'm trying to introduce a code mechanic that revolves around whether or not the end user retries, and I cannot realistically hook into the source function for Retrying, so I made this pull request in the hopes that this can resolve my problem, and it appears to currently

@Viv-0
Copy link
Author

Viv-0 commented Oct 20, 2021

I also spoke with an Everest dev who says it might make the most sense to make it a function inside level, which would resolve this conflict more efficiently with a different PR

@CrackedP0t
Copy link
Owner

This seems totally reasonable - I'd be happy to merge this, if you remove the changes to the csproj. If you think it should be changed that's fine, but I think it should be in a different PR.

@Viv-0
Copy link
Author

Viv-0 commented Oct 22, 2021

I'm going to wait a few days to try to get a response as to whether or not Everest will definitely make the Retry method a method inside Level because that would be a bigger help in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants