Upgrade Next.js to v13 - Part I #5402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nabramow
commented
Dec 31, 2024
Comment on lines
-48
to
+49
| //sentry testing was causing OOM for some reason | ||
| //const { testkit, sentryTransport } = sentryTestkit(); | ||
| //global.testKit = testkit; | ||
| const { testkit } = sentryTestkit(); | ||
| global.testKit = testkit; |
There was a problem hiding this comment.
Their next upgrade was focused mostly on performance and reducing bundle size so my guess was the OOM was happening due to that.
nabramow
commented
Dec 31, 2024
Comment on lines
-3
to
-5
| import { TFunction } from "i18n"; | ||
| import { StringMap, TOptions } from "i18next"; | ||
| import i18n from "test/i18n"; |
There was a problem hiding this comment.
They stopped exposing StringMap purposely (says in their docs). I tried to re-write this function but it was getting pretty gnarly, which is why I decided to just use the test instance of i18n in the tests and use the t function from there rather than mocking a separate one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the Next.js v13 upgrade. I will break this into two. This is doing the minimum to upgrade, which includes keeping some legacy behavior. The pages folder system will also be merged into the app folder and a lot of config will change. This version supports both ways. In part 2 I will change to new structure.
Migration Guide:
https://nextjs.org/docs/pages/building-your-application/upgrading/version-13
I needed to upgrade these packages as well for this:
This means you'll want to pay attention to translations and sentry while testing.
Web frontend checklist
yarn formatyarn lint --fix