Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New filters map #5116

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

New filters map #5116

wants to merge 2 commits into from

Conversation

bakeiro
Copy link
Contributor

@bakeiro bakeiro commented Nov 6, 2024

Draft PR!

note to self [really high memory usage]
image

Backend checklist

  • Formatted my code by running ruff check --select I --fix . && ruff check . && ruff format . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • Formatted my code with yarn format
  • There are no warnings from yarn lint --fix
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Nov 6, 2024 5:46pm

const isSmDown = useMediaQuery((theme: Theme) =>
theme.breakpoints.down("sm")
);

// TODO: should come from parent
const [valueSlider, setValueSlider] = useState<number[]>([20, 37]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabramow here should be 18 - 100 by default, since these are the default backend values (if I'm not wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant