Merge branch 'frontend/refactor/remove-storybook' into develop

.github/pull_request_template.md

@@ -20,7 +20,6 @@ If you need help with any of these, please ask :)
 - [ ] Formatted my code with `yarn format`
 - [ ] There are no warnings from `yarn lint --fix`
 - [ ] There are no console warnings when running the app
-- [ ] Added any new components to storybook
 - [ ] Added tests where relevant
 - [ ] All tests pass
 - [ ] Clicked around my changes running locally and it works

app/.gitlab-ci.yml

@@ -380,28 +380,6 @@ test:web-linting:
       changes:
         - app/web/**/*
 
-test:storybook:
-  needs: ["build:web-dev"]
-  stage: test
-  image: $WEB_DEV_TAG
-  inherit:
-    # no docker login
-    default: false
-  script:
-    - cd /app && yarn build-storybook
-    - mkdir -p $CI_PROJECT_DIR/artifacts/storybook-static && cp -a /app/storybook-static $CI_PROJECT_DIR/artifacts/
-  artifacts:
-    paths:
-      - artifacts/storybook-static
-  rules:
-    - if: ($BUILD_WEB == "true") && ($DO_CHECKS == "true") && ($CI_COMMIT_BRANCH == $RELEASE_BRANCH)
-      changes:
-        - app/**/*
-    - if: ($BUILD_WEB == "true") && ($DO_CHECKS == "true") && ($CI_COMMIT_BRANCH != $RELEASE_BRANCH)
-      changes:
-        - app/proto/**/*
-        - app/web/**/*
-
 test:proxy:
   needs: ["build:proxy"]
   stage: test
@@ -471,28 +449,6 @@ preview:wcov:
         - app/proto/**/*
         - app/web/**/*
 
-preview:storybook:
-  needs: ["test:storybook"]
-  stage: preview
-  image: registry.gitlab.com/gitlab-org/cloud-deploy/aws-base:latest
-  inherit:
-    # no docker login
-    default: false
-  script:
-    - aws s3 rm s3://$AWS_PREVIEW_BUCKET/storybook/$CI_COMMIT_SHORT_SHA/ --recursive
-    - aws s3 cp artifacts/storybook-static s3://$AWS_PREVIEW_BUCKET/storybook/$CI_COMMIT_SHORT_SHA/ --recursive
-    - aws s3 rm s3://$AWS_PREVIEW_BUCKET/storybook/$CI_COMMIT_REF_SLUG/ --recursive
-    - aws s3 cp artifacts/storybook-static s3://$AWS_PREVIEW_BUCKET/storybook/$CI_COMMIT_REF_SLUG/ --recursive
-    - echo "Done, storybook available at https://$CI_COMMIT_SHORT_SHA--storybook.$PREVIEW_DOMAIN/ and https://$CI_COMMIT_REF_SLUG--storybook.$PREVIEW_DOMAIN/"
-  rules:
-    - if: ($BUILD_WEB == "true") && ($DO_CHECKS == "true") && ($CI_COMMIT_BRANCH == $RELEASE_BRANCH)
-      changes:
-        - app/**/*
-    - if: ($BUILD_WEB == "true") && ($DO_CHECKS == "true") && ($CI_COMMIT_BRANCH != $RELEASE_BRANCH)
-      changes:
-        - app/proto/**/*
-        - app/web/**/*
-
 preview:web:
   needs: ["build:web"]
   stage: preview
@@ -630,9 +586,6 @@ wait:before-release:
     - job: test:web-linting
       artifacts: false
       optional: true
-    - job: test:storybook
-      artifacts: false
-      optional: true
 
 release:proxy:
   needs: ["wait:before-release"]

app/web/.eslintrc.json

@@ -3,7 +3,6 @@
     "plugin:@typescript-eslint/recommended",
     "next",
     "next/core-web-vitals",
-    "plugin:storybook/recommended",
     "prettier"
   ],
   "plugins": ["@typescript-eslint", "simple-import-sort", "unused-imports"],
@@ -38,22 +37,11 @@
     "@typescript-eslint/no-non-null-assertion": "off",
     //used in testing
     "@typescript-eslint/no-empty-function": "off",
-    //don't care about this that much
-    "storybook/prefer-pascal-case": "off",
     //not using this right now
     "@next/next/no-img-element": "off",
     //this is ugly
     "react/no-unescaped-entities": "off",
     // Prefer inferred types so that the code is as close to JS as possible
     "@typescript-eslint/explicit-module-boundary-types": "off"
-  },
-  "overrides": [
-    //allow any in stories
-    {
-      "files": ["**/*.stories.tsx"],
-      "rules": {
-        "@typescript-eslint/no-explicit-any": "off"
-      }
-    }
-  ]
+  }
 }

app/web/.gitignore

@@ -38,8 +38,6 @@ yarn-error.log*
 
 proto/**
 
-storybook-static/
-
 junit.xml