-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.15.2 and start deprecating singular tags #47
Conversation
How about pre2 now that it's out |
Got it to pre2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good. Just wanna clarify some things.
src/main/resources/data/minecraft/tags/blocks/natural_stone.json
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/resources/mixin/MixinVanillaOregen.java
Outdated
Show resolved
Hide resolved
You mentioned changing the oregen spec over in Discord. Did that change go through? |
That is going to be part of the detachment of world Gen from CR. Which is going to take a bit longer. |
Should probably become 1.15 now |
I've realized that some parts need a general rewrite, so I've decided to isolate oregen into a new isolated system. Mainly due to biome and dimension specs having an issue because they load before tags are ever handled. I'll probably name the new ore system StaticOre (because it uses static data) and then implement the current CR system onto it. In that case CR will just be giving the ores it want generated to the ore generator if anything wants ore. |
Is there anything else that needs to be fixed before this can be merged? |
Looked at codebase again and see if I could make dimension/biome tags work properly. I think I just need to add a mixin to RegistryTagManager so it is loaded at the same time as the block tags. I'll do more work tomorrow on it. |
This is looking pretty good! Feel free to make any breaking changes you deem necessary, since there currently aren't any mods that actually use this lol. |
Fixes #46
Changes proposed in this pull request:
Note I also found an issue where if there was no replacer specified for any of the stone blocks, the overworld version of the ores would fail to actually generate.