Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos on linux, improved better as per a request #2836

Closed
wants to merge 4 commits into from
Closed

Cosmos on linux, improved better as per a request #2836

wants to merge 4 commits into from

Conversation

PratyushKing
Copy link
Contributor

As per a requet from @pleasenoban, I have made it such that the debug enabled is only disabled on a specific new template called csharp-linux, and yes I have also updated the docs for linux users who want to install the templates. If anyone has further queries please do tell.

@valentinbreiz
Copy link
Member

valentinbreiz commented Dec 5, 2023

Shouldn't we just disable debugging by default instead of adding the same code?

@PratyushKing
Copy link
Contributor Author

Shouldn't we just disable debugging by default instead of adding the same code?

I did it but @pleasenoban saw that on windows it somehow made it worse so I did this. Don't worry I tested it in both OS

@valentinbreiz
Copy link
Member

Shouldn't we just disable debugging by default instead of adding the same code?

I did it but @pleasenoban saw that on windows it somehow made it worse so I did this. Don't worry I tested it in both OS

what do you think @quajak?

@quajak
Copy link
Member

quajak commented Dec 5, 2023

I did it but @pleasenoban saw that on windows it somehow made it worse so I did this. Don't worry I tested it in both OS

How is it worse? I think it's better if we disable it by default

@Jspa2
Copy link
Contributor

Jspa2 commented Dec 5, 2023

Adding a separate template for Linux is overcomplicating things. I think debugging should be switched off by default for all platforms.

@valentinbreiz
Copy link
Member

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants