Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xharp checkout back #2483

Merged
merged 47 commits into from
Oct 13, 2023
Merged

Add xharp checkout back #2483

merged 47 commits into from
Oct 13, 2023

Conversation

charlesbetros
Copy link
Member

@charlesbetros charlesbetros commented Nov 22, 2022 •
edited by valentinbreiz
Loading

todo:

  • Fix kernel tests
  • Remove appveyor CI
  • Update RestoreSources.props

@charlesbetros
Enable pckage lockfiles
4a60eda
@charlesbetros
Add xharp checkout back
2f5cd7a
@charlesbetros
Add checkout Common back
56e39bb
@charlesbetros
Merge branch 'task/enable-package-lockfiles' into task/ghaction
4cb100f
@charlesbetros
Set Bochs run command from string instead of env var
afe0802
@charlesbetros
Switch to windows cmd shell instead of powershell
75b5c4d
@charlesbetros
Get User Kit Path env var properly
ec95607
@charlesbetros
Merge branch 'master' into task/ghaction
10b0ff8
@charlesbetros
Set environment variable for bochs cmd
dea9c99
@charlesbetros
Use proper way to get program files path
4359fdf
@charlesbetros
Merge branch 'master' into task/ghaction
4223e6a
@charlesbetros
Add continue-on-error
0a997bf
@charlesbetros
Add env to get TestResults.xml
040a606
@charlesbetros
Remove $
39fdb59
@charlesbetros
Try using matrix for parallel test
631afee
@charlesbetros
Try using outputs
a18178d
@charlesbetros
Fix string concat
2bacf0e
@charlesbetros
Fix tets runner path
455a165
@charlesbetros
Add some debug output
f30a33b
@charlesbetros
Fix csproj path
1ee4419
@charlesbetros
Set output properly
ad13aea
@charlesbetros
Make matrix an array
50392c1
@charlesbetros
Try converting matrix values to json
d4ca58a
@charlesbetros
Trying toJSON
cc466e6
@charlesbetros
Use correct env var
8ebb4fc
@charlesbetros
Try array as string
98b8eb9
@charlesbetros
Hardcode matrix
7abad9b
@charlesbetros
Use test name from matrix
5874bd8
@charlesbetros
Publish tests so we don't have to rebuild them
27608e4
@charlesbetros
Relative path
c770744
@valentinbreiz valentinbreiz force-pushed the task/ghaction branch 2 times, most recently from 4c8b2a5 to 43dd523 Compare September 29, 2023 08:08
@valentinbreiz valentinbreiz force-pushed the task/ghaction branch 2 times, most recently from 49a292d to aa1ede4 Compare September 29, 2023 15:00
@valentinbreiz valentinbreiz marked this pull request as ready for review October 2, 2023 07:00
@valentinbreiz valentinbreiz requested review from quajak and zarlo October 2, 2023 07:00
zarlo
zarlo reviewed Oct 2, 2023
View reviewed changes
.github/workflows/pr.yml

strategy:
matrix:
kernel: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a note somewhere that when you make new tests you need to add them here

@quajak quajak merged commit 95a6434 into master Oct 13, 2023
17 checks passed
@quajak quajak deleted the task/ghaction branch October 13, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarlo zarlo zarlo left review comments

@MishaProductions MishaProductions MishaProductions approved these changes

@quajak quajak Awaiting requested review from quajak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@charlesbetros @zarlo @MishaProductions @quajak @MishaTy @valentinbreiz