✨ Use dynamic TCP ports + prevent user to choose TCP client port

CosmosOS · Oct 31, 2023 · d689fed · d689fed
1 parent 7ef43d1
commit d689fed
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/Tests/Kernels/NetworkTest/Kernel.cs b/Tests/Kernels/NetworkTest/Kernel.cs
@@ -154,7 +154,7 @@ private void TestTcpConnection()
         {
             Global.debugger.Send("Creating TCP client...");
 
-            using (var xClient = new TcpClient(4242))
+            using (var xClient = new TcpClient())
             {
                 Assert.IsTrue(xClient.IsClosed(), "TCP connexion created.");
 

diff --git a/source/Cosmos.System2/Network/IPv4/TCP/TCPClient.cs b/source/Cosmos.System2/Network/IPv4/TCP/TCPClient.cs
@@ -15,6 +15,15 @@ public class TcpClient : IDisposable
         /// </summary>
         public Tcp StateMachine;
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="TcpClient"/> class.
+        /// </summary>
+        /// <exception cref="ArgumentOutOfRangeException">Thrown on fatal error.</exception>
+        /// <exception cref="ArgumentException">Thrown if TcpClient with localPort 0 exists.</exception>
+        public TcpClient() : this(Tcp.GetDynamicPort())
+        {
+        }
+
         /// <summary>
         /// Initializes a new instance of the <see cref="TcpClient"/> class.
         /// </summary>
@@ -32,7 +41,7 @@ internal TcpClient(Tcp stateMachine)
         /// <param name="localPort">The local port.</param>
         /// <exception cref="ArgumentOutOfRangeException">Thrown on fatal error.</exception>
         /// <exception cref="ArgumentException">Thrown if localPort already exists.</exception>
-        public TcpClient(int localPort)
+        internal TcpClient(int localPort)
         {
             StateMachine = new((ushort)localPort, 0, Address.Zero, Address.Zero);
             StateMachine.RxBuffer = new Queue<TCPPacket>(8);
@@ -47,7 +56,7 @@ public TcpClient(int localPort)
         /// <exception cref="ArgumentOutOfRangeException">Thrown on fatal error.</exception>
         /// <exception cref="ArgumentException">Thrown if TcpClient with localPort 0 exists.</exception>
         public TcpClient(Address dest, int destPort)
-            : this(0)
+            : this(Tcp.GetDynamicPort())
         {
             StateMachine.RemoteEndPoint.Address = dest;
             StateMachine.RemoteEndPoint.Port = (ushort)destPort;