Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added management command for simple use of create_public_tenant #565

Merged
merged 4 commits into from
May 6, 2024

Conversation

jgentil
Copy link
Contributor

@jgentil jgentil commented May 1, 2024

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

@jgentil
Copy link
Contributor Author

jgentil commented May 3, 2024

@Dresdn tagging you since I can't assign a reviewer. We added this command locally to our project and I figured it would be a good contribution.

@Dresdn
Copy link
Collaborator

Dresdn commented May 3, 2024

Thanks @jgentil! Appreciate the contribution.

@Dresdn
Copy link
Collaborator

Dresdn commented May 4, 2024

@jgentil FYI that the tests are failing, but I did take this opportunity to update all dependencies to latest supported ones

@jgentil
Copy link
Contributor Author

jgentil commented May 6, 2024

Ah I need to fix the f string to support Python 3.7.

@Dresdn
Copy link
Collaborator

Dresdn commented May 6, 2024

I just cleaned up the dependencies of EOL versions, so 3.7 isn't an issue anymore.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (2b2c385) to head (899b0ec).
Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   88.36%   89.05%   +0.68%     
==========================================
  Files          18       20       +2     
  Lines         619      658      +39     
  Branches      116      118       +2     
==========================================
+ Hits          547      586      +39     
  Misses         62       62              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dresdn
Copy link
Collaborator

Dresdn commented May 6, 2024

Thanks! I'll do a release here, too, so we can get this and Django 5.0 support out the door.

@jgentil
Copy link
Contributor Author

jgentil commented May 6, 2024

I just cleaned up the dependencies of EOL versions, so 3.7 isn't an issue anymore.

Oh. Haha oh well, I guess that works too then!

@Dresdn Dresdn merged commit 2194126 into Corvia:master May 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants