Made a numeric_t typedef to make changing it later on easier

This is pretty much related to issue #5, numeric_t currently is still int,
so everything is behaving exactly as it was.

include/data.h

@@ -78,7 +78,7 @@ class Data
      *  @return Data        Same object for chaining
      */
     Data &assign(const char *name, const std::string &value);
-    Data &assign(const char *name, int value);
+    Data &assign(const char *name, numeric_t value);
     Data &assign(const char *name, Value *value);
 
     /**

include/empty.h

@@ -30,9 +30,9 @@ class EmptyValue : public Value
 
     /**
      *  Convert the variable to a numeric value
-     *  @return int
+     *  @return numeric
      */
-    virtual int toNumeric() override
+    virtual numeric_t toNumeric() override
     {
         return 0;
     }

include/map.h

@@ -69,9 +69,9 @@ class MapValue : public Value
 
     /**
      *  Convert the variable to a numeric value
-     *  @return int
+     *  @return numeric
      */
-    virtual int toNumeric() override
+    virtual numeric_t toNumeric() override
     {
         return 0;
     }
@@ -113,7 +113,7 @@ class MapValue : public Value
      *  @param  value       Value of the variable
      *  @return MapValue    Same object for chaining
      */
-    MapValue& assign(const char *name, int value)
+    MapValue& assign(const char *name, numeric_t value)
     {
         // append variable
         _values[name] = std::unique_ptr<Value>(new NumericValue(value));

include/numeric.h

@@ -20,9 +20,9 @@ class NumericValue : public Value
 private:
     /**
      *  Underlying value
-     *  @var int
+     *  @var numeric
      */
-    const int _value;
+    const numeric_t _value;
 
     /**
      *  String representation
@@ -35,7 +35,7 @@ class NumericValue : public Value
      *  Constructor
      *  @param  value
      */
-    NumericValue(int value) : _value(value) {}
+    NumericValue(numeric_t value) : _value(value) {}
 
     /**
      *  Destructor
@@ -58,9 +58,9 @@ class NumericValue : public Value
 
     /**
      *  Convert the variable to a numeric value
-     *  @return int
+     *  @return numeric
      */
-    virtual int toNumeric() override
+    virtual numeric_t toNumeric() override
     {
         return _value;
     }

include/string.h

@@ -49,12 +49,12 @@ class StringValue : public Value
 
     /**
      *  Convert the variable to a numeric value
-     *  @see std::atoi
-     *  @return int
+     *  @see std::strtoul
+     *  @return numeric
      */
-    virtual int toNumeric() override
+    virtual numeric_t toNumeric() override
     {
-        return std::atoi(_value.c_str());
+        return std::strtoul(_value.c_str(), (char**) NULL, 10);
     }
 
     /**

include/value.h

@@ -12,6 +12,12 @@
  *  Set up namespace
  */
 namespace SmartTpl {
+
+/**
+ *  Typedef for a general numeric type, if we ever decide to change it we'll just
+ *  have to modify this.
+ */
+typedef int numeric_t;
 
 /**
  *  Class definition
@@ -28,9 +34,9 @@ class Value
 
     /**
      *  Convert the variable to a numeric value
-     *  @return int
+     *  @return numeric
      */
-    virtual int toNumeric() = 0;
+    virtual numeric_t toNumeric() = 0;
 
     /**
      *  Convert the variable to a boolean value

src/bytecode.cpp

@@ -275,7 +275,7 @@ void Bytecode::string(const std::string &value)
  *  @param  value
  *  @note   +1 on the stack
  */
-void Bytecode::numeric(int value)
+void Bytecode::numeric(numeric_t value)
 {
     // push value
     _stack.push(_function.new_constant(value, jit_type_sys_int));

src/bytecode.h

@@ -151,7 +151,7 @@ class Bytecode : private Generator, public Executor
      *  @param  value
      */
     virtual void string(const std::string &value) override;
-    virtual void numeric(int value) override;
+    virtual void numeric(numeric_t value) override;
 
     /**
      *  Create a string or numeric constant for a variable

src/ccode.cpp

@@ -196,7 +196,7 @@ void CCode::string(const std::string &value)
  *  Create a numeric literal
  *  @param  value
  */
-void CCode::numeric(int value)
+void CCode::numeric(numeric_t value)
 {
     // output number
     _out << value;

src/ccode.h

@@ -78,7 +78,7 @@ class CCode : public Generator
      *  @param  value
      */
     virtual void string(const std::string &value) override;
-    virtual void numeric(int value) override;
+    virtual void numeric(numeric_t value) override;
 
     /**
      *  Create a string, numeric or boolean constant for a variable

src/data.cpp

@@ -47,7 +47,7 @@ Data &Data::assign(const char *name, const std::string &value)
  *  @param  value       Value of the variable
  *  @return Data        Same object for chaining
  */
-Data &Data::assign(const char *name, int value)
+Data &Data::assign(const char *name, numeric_t value)
 {
     // append variable
     _variables[name] = std::unique_ptr<Value>(new NumericValue(value));

src/generator.h

@@ -94,7 +94,7 @@ class Generator
      *  @param  value
      */
     virtual void string(const std::string &value) = 0;
-    virtual void numeric(int value) = 0;
+    virtual void numeric(numeric_t value) = 0;
     //virtual void boolean(bool value) = 0;
 
     /**

src/includes.h

@@ -1,7 +1,7 @@
 /**
  *  Includes.h
  * 
- *  Header file that includes all public header files of the SmartTpl library
+ *  Header file that includes all header files of the SmartTpl library
  * 
  *  @author Emiel Bruijntjes <[email protected]>
  *  @copyright 2014 Copernica BV