Get single-site blog working #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home.php has a reserved status in the WordPress template hierarchy.
Get set for a single blog on non-multisite install.
|
Looks like some good clean up! |
|
(I've made the change locally and filed #112 for the others to do so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our local instances are single-site and I expect our initial production instance to be single-site. However, bfn.context.org is multisite and we've been carrying the multisite / multiblog setup along from that.
This PR addresses that through changes in
bfc_top_nav_menu_builder()andbfc_top_nav_is_active()I also needed to rename
home.phptohomepage.php.home.phpturns out to be a reversed name in the WordPress template hierarchy and was forcingdev.bfcom.local/blog/to usehome.phpwhich is meant for the non-blog home page. I got clues to this from Blog Page Redirects To Homepage and from Query Monitor's template listing.You will need to make some Admin changes to mesh with the coding changes.
bfnet-blogto justblog.This change can be made before merging the new version.