Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exports for sunpkcs11-wrapper #922

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add exports for sunpkcs11-wrapper #922

merged 1 commit into from
Oct 5, 2023

Conversation

usmansaleem
Copy link
Contributor

PR Description

Add exports for sunpkcs11-wrapper in launch script.

Fixed Issue(s)

#916

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem usmansaleem mentioned this pull request Oct 4, 2023
Closed
jframe
jframe approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit 5d972d7 into Consensys:master Oct 5, 2023
2 checks passed
@usmansaleem usmansaleem deleted the yubihsm_java17 branch October 5, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe