Docker tag prefixes for RC versions #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- create latest and x.y tag prefixes for non-develop and non-rc releases
jframe
approved these changes
Sep 6, 2023
| versionPrefixes.add('latest') | ||
| // when docker build version is x.y.[a,b..] we would also like to use tag x.y |
There was a problem hiding this comment.
Guess this doesn't hurt, but probably don't need this either
There was a problem hiding this comment.
It was already part of existing logic, I simply added the comment for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Create
latestandx.ydocker tag prefixes only for non-develop and non-rc releases. This will allow to create releases such as 23.9.0-RC1 which doesn't update the latest and 23.9 docker tags.Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing