Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holesky #900

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Holesky #900

merged 3 commits into from
Sep 6, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Sep 6, 2023

PR Description

Add support for the holesky network

  • Update to the latest Teku version that includes holesky
  • Hard code version of Teku in the acceptance tests so we have the test fixtures necessary to for the acceptance tests
  • Fix invalid config for the custom network AT

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@jframe jframe marked this pull request as ready for review September 6, 2023 03:42
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe merged commit a1bf6ba into Consensys:master Sep 6, 2023
2 checks passed
@jframe jframe deleted the holesky branch September 6, 2023 04:29
@@ -8,7 +8,8 @@
### Features Added
- Signing support for BlobSidecar and BlindedBlobSidecar in Deneb fork.
- Add `--azure-response-timeout` to allow request response timeout to be configurable, the field `timeout` is also accepted in the Azure metadata file. [#888](https://github.com/Consensys/web3signer/pull/888)
- Bulk load Ethereum v3 wallet files in eth1 mode.
- Bulk load Ethereum v3 wallet files in eth1 mode.
- Add network configuration for Holesky testnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add the link of the PR in the changelog? I usually do add them and personally like to have them there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants