Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcheck should allow a plain text accept header #895

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Upcheck should allow a plain text accept header #895

merged 3 commits into from
Aug 31, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Aug 31, 2023 •
edited
Loading

PR Description

The Upcheck should allow a plain text accept header to match the API definition.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@jframe jframe requested a review from gfukushima August 31, 2023 06:50
gfukushima
gfukushima approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jframe jframe changed the title Upcheck should produce a plain text response Upcheck should allow a plain text accept header Aug 31, 2023
@jframe jframe enabled auto-merge (squash) August 31, 2023 06:57
@jframe jframe merged commit 89816e1 into Consensys:master Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @gfukushima