Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deneb block signing #868

Merged
merged 13 commits into from
Aug 18, 2023
Merged

Deneb block signing #868

merged 13 commits into from
Aug 18, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Aug 2, 2023

PR Description

Support signing of Deneb blocks and blinded block signing. This only implements the signing of the Deneb blocks it does add signing for blob sidecars.

Since changes for Deneb block are in the execution payload and web3signer uses the BeaconBlockHeader we don't need to make changes to the block type.

The changes to the open API spec are being done directly with the existing signing spec in web3signer. In the future a PR will move the specs to be taken from the new remote-signing-api repository.

Fixed Issue(s)

fixes #858

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

jframe and others added 7 commits August 2, 2023 10:54
* build.gradle: Java 17
* circleci: Java 17
* build.gradle: removing jdk11 docker tag
* changelog
* license reporting config: MIT license normalized
* Update gatling (performance test) gradle plugin version
* CircleCI: Install Java 17 for machine executors
* circleci: machine image to use ubuntu-2204:current
@jframe jframe marked this pull request as ready for review August 16, 2023 03:50
@jframe jframe changed the title Deneb Deneb block signing Aug 16, 2023
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jframe jframe merged commit 8595ae2 into Consensys:master Aug 18, 2023
2 checks passed
@jframe jframe deleted the deneb branch August 18, 2023 03:41
@macladson macladson mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deneb Open API spec changes
3 participants