-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deneb block signing #868
Merged
Merged
Deneb block signing #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* build.gradle: Java 17 * circleci: Java 17 * build.gradle: removing jdk11 docker tag * changelog * license reporting config: MIT license normalized * Update gatling (performance test) gradle plugin version * CircleCI: Install Java 17 for machine executors * circleci: machine image to use ubuntu-2204:current
This reverts commit 39f09b0.
usmansaleem
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Support signing of Deneb blocks and blinded block signing. This only implements the signing of the Deneb blocks it does add signing for blob sidecars.
Since changes for Deneb block are in the execution payload and web3signer uses the BeaconBlockHeader we don't need to make changes to the block type.
The changes to the open API spec are being done directly with the existing signing spec in web3signer. In the future a PR will move the specs to be taken from the new remote-signing-api repository.
Fixed Issue(s)
fixes #858
Documentation
doc-change-required
label to this PR if updates are required.Changelog
Testing