Commit Boost Acceptance Test for List Pub Keys #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
usmansaleem
added
the
TeamCerberus
jframe
reviewed
Nov 25, 2024
| * @param identifier The identifier for which to sign data. | ||
| * @param data Bytes which is signed | ||
| * @return Optional ArtifactSignature of type T. Empty if no signer available for given identifier | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public <T extends ArtifactSignature<?>> Optional<T> signAndGetArtifactSignature( |
There was a problem hiding this comment.
Removing this means we need to cast in some places
There was a problem hiding this comment.
This is currently used only at one place, in TransactionSerializer.
There was a problem hiding this comment.
Let me try to see if we can eliminate this method altogether.
There was a problem hiding this comment.
@jframe I've eliminated this method. TransactionSerializer can reconstruct SignatureData from the hex String.
-- derive SignatureData from existing SecpArtifactSignature builder method
jframe
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add commit boost acceptance test for list pub keys API. Also fix the public key identifiers used by commit boost by introducing K256ArtifactSigner.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing