-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit boost API - Generate Proxy Key, Signing Request #1033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Implement route and handlers for /signer_v1_get_pubkeys
-- Added routes and handler
usmansaleem
added
the
TeamCerberus
Under active development by TeamCerberus @Consensys
label
Oct 22, 2024
9 tasks
signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/EthPublicKeyUtils.java
Fixed
Show fixed
Hide fixed
signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/EthPublicKeyUtils.java
Dismissed
Show dismissed
Hide dismissed
.../src/test/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProviderTest.java
Fixed
Show fixed
Hide fixed
# Conflicts: # signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
usmansaleem
changed the title
Commit boost API - Generate Proxy Key
Commit boost API - Generate Proxy Key, Signing Request
Nov 1, 2024
-- extract artifactsignerprovider in route instead of handler
-- Fix incorrect logic of lookig up proxy signers
@jframe this monstrous PR is ready for review, give it a go at your convenience :) |
usmansaleem
added
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Nov 18, 2024
Is there anyway to break this PR into smaller PRs? It's quite big to review at the moment |
Closing as PR was too long. |
usmansaleem
removed
doc-change-required
Indicates an issue or PR that requires doc to be updated
TeamCerberus
Under active development by TeamCerberus @Consensys
labels
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Commit boost API - Generate Proxy Key, Request Signature. Implementation of https://commit-boost.github.io/commit-boost-client/api
CommitBoostGenerateProxyKeyHandler
,CommitBoostGenerateProxyKeyRoute
BLSProxyDelegation
,SECPProxyDelegation
,ProxyDelegation
)ProxyKeyGenerator
andSigningRootGenerator
)Other changes:
DepositSigningRootUtil
toWeb3SignerSigningRootUtil
EthPublicKeyUtils
to use Bouncycastle libraries to handle SECP Keys.CommitBoostParameters
interface andPicoCommitBoostApiParameters
implementationPicoCliNetworkOverrides
CommitBoostGenerateProxyKeyRoute
Fixed Issue(s)
See #1017
Documentation
doc-change-required
label to this PR if updates are required.Changelog
Testing