Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit boost API - Generate Proxy Key, Signing Request #1033

Closed

Conversation

usmansaleem
Copy link
Contributor

@usmansaleem usmansaleem commented Oct 21, 2024

PR Description

Commit boost API - Generate Proxy Key, Request Signature. Implementation of https://commit-boost.github.io/commit-boost-client/api

  • Routes and Handler for Generate Proxy Key CommitBoostGenerateProxyKeyHandler, CommitBoostGenerateProxyKeyRoute
  • Custom SSZ classes for calculating signing roots (BLSProxyDelegation, SECPProxyDelegation,ProxyDelegation)
  • Create BLS and/or SECP proxy keys (utility classes ProxyKeyGenerator and SigningRootGenerator)
  • Unit/Acceptance tests

Other changes:

  • Renamed DepositSigningRootUtil to Web3SignerSigningRootUtil
  • Refactored EthPublicKeyUtils to use Bouncycastle libraries to handle SECP Keys.
  • Introduced CommitBoostParameters interface and PicoCommitBoostApiParameters implementation
  • Use ZERO genesis validators root for commit boost API. However, added additional code to use actual GVR if Commit Boost client changes its implementation in future.
  • Updated Eth2Subcommand. Moved network overrides cli options to mixin class PicoCliNetworkOverrides
  • Updated Eth2Runner and register CommitBoostGenerateProxyKeyRoute
  • Updated SECP bulkloader to handle compressed public keys as identifiers
  • Updated DefaultArtifactProvider to add proxy signers. Refactored the code to make it a bit cleaner

Fixed Issue(s)

See #1017

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem usmansaleem self-assigned this Oct 22, 2024
@usmansaleem usmansaleem added the TeamCerberus Under active development by TeamCerberus @Consensys label Oct 22, 2024
@usmansaleem usmansaleem changed the title Commit boost API - Generate Proxy Key Commit boost API - Generate Proxy Key, Signing Request Nov 1, 2024
@usmansaleem usmansaleem marked this pull request as draft November 4, 2024 00:29
@usmansaleem usmansaleem marked this pull request as ready for review November 14, 2024 10:29
@usmansaleem
Copy link
Contributor Author

@jframe this monstrous PR is ready for review, give it a go at your convenience :)

@usmansaleem usmansaleem added the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 18, 2024
@jframe
Copy link
Contributor

jframe commented Nov 19, 2024

@jframe this monstrous PR is ready for review, give it a go at your convenience :)

Is there anyway to break this PR into smaller PRs? It's quite big to review at the moment

@usmansaleem usmansaleem marked this pull request as draft November 21, 2024 08:19
@usmansaleem
Copy link
Contributor Author

Closing as PR was too long.

@usmansaleem usmansaleem removed doc-change-required Indicates an issue or PR that requires doc to be updated TeamCerberus Under active development by TeamCerberus @Consensys labels Nov 28, 2024
@usmansaleem usmansaleem deleted the commit_boost_gen_proxy branch December 2, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants