Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny blobs pruner fix #8854

Merged
merged 1 commit into from
Nov 27, 2024
Merged

tiny blobs pruner fix #8854

merged 1 commit into from
Nov 27, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Nov 27, 2024 •
edited
Loading

As a consequence of having specConfig versions aligned with milestones, we can't assume config to be deneb in blobs pruner.
Starting up a pre-deneb genesis we can print a lot of exceptions until deneb activates.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

mehdi-aouadi
mehdi-aouadi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr merged commit d5528fa into Consensys:master Nov 27, 2024
16 of 17 checks passed
@tbenr tbenr deleted the blob-pruner-tiny-fix branch November 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdi-aouadi mehdi-aouadi mehdi-aouadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @mehdi-aouadi