fix: improve Fee Token Selection UX with Disclaimer and Error Messaging #433
+52
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
requested review from
Akaryatrh and
wantedsystem
and removed request for
a team
packages/starknet-snap/src/ui/controllers/user-input-event-controller.ts
Show resolved
Hide resolved
packages/starknet-snap/src/ui/controllers/user-input-event-controller.test.ts
Outdated
Show resolved
Hide resolved
stanleyyconsensys
approved these changes
Nov 25, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
This PR improves the user experience for fee token selection by adding a default disclaimer and clearer error messaging:
If the chosen token has no funds, the system will automatically switch to a funded token.Not enough STRK to pay for fees. The fee token has been switched back to ETH.Why This Change?
BEGIN_COMMIT_OVERRIDE
chore: Improve Fee Token selection UX with better Error Messaging and Disclaimer
END_COMMIT_OVERRIDE