Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'featureBounds' method to use 'forEachLatLng' #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peteroomen
Copy link

I made a change to the 'featureBounds' function, so it would support complex geometries, with more than one level of nesting. It was only traversing one layer of the Geometry's points, when in fact Geometries can have any amount of nesting. One example of complex geometries of this type is the 'MultiPolygon' https://tools.ietf.org/html/rfc7946#section-3.1.7
My change to the function makes it use google's forEachLatLng method, provided for geometries. This method iterates over each LatLng of a geometry, regardless of what kind of geometry it is, and how many layers of geometries and points it contains. I use this method to extend the bounds using each LatLng inside the Geometry.

@Connum
Copy link
Owner

Connum commented Sep 19, 2017

Sorry for not reacting to this yet. I didn'd have the time for looking into this so far, as I'm not currently working on the project for which I created this fork. As soon as I pick that up, I'll give it a try and see if it breaks anything for me. Thanks for the contribution, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants