Fix empty checks followup 2 #333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2022 22:44
…imes. normalize-space() can only take a single string value. This works fine for xpath expressions that return a single node, but not for expressions that return a node list. This results in a run-time XPath error when validating documents that have multiple nodes that match an expression within a context. This commit changes the test expressions for empty values to an 'every $ in satisfies' clause. Note that most of these won't occur in a situation where the XML Schema is properly checked. However, because the result would be an Xpath error rather than a failed test, it's better to use this approach for all fields where we check emptiness by a normalize-space() != '' expression.
tjeb
pushed a commit
to peppolautoriteit-nl/validation
that referenced
this pull request
Nov 1, 2022
Without the existence check, the tests incorrectly pass if the relevant element is left out completely.
tjeb
added a commit
to peppolautoriteit-nl/validation
that referenced
this pull request
Feb 28, 2023
ConnectingEurope/eInvoicing-EN16931#333 - Fixed an issue introduced in 2.0.3.5. This version contained an additional change in checks for empty values for a number rules. This change added a check for whitespace-only as well, but contained an issue where the entire check was skipped if the checked XML element is not present. This issue has been fixed in this version, by explicitely checking both existence and white-space aware emptiness.
tjeb
pushed a commit
to peppolautoriteit-nl/validation
that referenced
this pull request
May 3, 2023
The EN-16931 validation rules that are used in SI-UBL 2.0, the g-account extension, and NLCIUS-CII have been updated to version 1.3.10, but include the currently open Pull Request 333: ConnectingEurope/eInvoicing-EN16931#333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request in #332 was bad, in that it wouldn't catch individual empty elements if the full node list wasn't empty.
This is a second proposal, that uses the 'every node in satisfies' construct.