-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded CosmWasm runtime in Picasso to latest dependencies #3677
Conversation
Picasso Preview URLhttps://picasso-production-i1par7xjl-composable-finance.vercel.app |
This should be split into multiple PRs. It’s quite hard to review as it mixes multiple changes into one. For example, XCVM → XC rename could easily be done in a separate PR. I’ve done cursory read through and so far looks good but haven’t reviewed it properly yet. |
all changes are really easy, very stupid pr just doing cargo staff, some rename and clean up. what else should i do waiting for rust to compile? ) |
Each individual change may be easy, but once you package them into a single PR they all produce big PR which is hard to read since each diff line corresponds to different thing being changed. You could have for example rename XCVM to XC, send that as a PR, and continue working on the next thing even on the same local branch. |
as soon as somebody proves it works with rebases - sure. will do exactly that |
What do you mean proves it works with rebases? I’ve been using rebases entire time I've been using git and they work great. |
@mina86 show me you operated like you said - i would happy to follow. i have not seen you do PR, and than another PR on top of PR from same branch. like first PR into main. second PR into first PR. etc I feel it does not work well in our context, but I may be wrong. |
<name>-no-std
later . all forks are PRs and issues on CW team reposcargo-package-build> thread 'tests::suite::cross_chain::test_simple_crosschain_xcvm_transfer' panicked at 'Must be able
which was before my commit anywaymisc
label if it should not be in release notespr-workflow-check / draft-release-check
to finish with success(green check mark) with my changes