Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squashed commit of the following: #269

Closed
wants to merge 3 commits into from
Closed

Squashed commit of the following: #269

wants to merge 3 commits into from

Conversation

danielbanda
Copy link
Contributor

Closes #85

Fixed some documentation typos 😉

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 @Nirmal4G same as #237 but squashed.

@danielbanda
Squashed commit of the following:
c9615f6 
commit f77303a
Author: Daniel Banda <[email protected]>
Date:   Tue May 3 21:43:11 2022 -0700

    Reverting accidental commit.

    Reverting accidental commit.

commit ea9740b
Author: Daniel Banda <[email protected]>
Date:   Tue May 3 21:30:55 2022 -0700

    Fixing typos

    Found some typos while reviewing the library.

commit f2dce06
Author: Daniel Banda <[email protected]>
Date:   Tue May 3 21:21:10 2022 -0700

    Fixing some typos.
Nirmal4G
Nirmal4G suggested changes May 25, 2022
View reviewed changes
Copy link
Contributor

@Nirmal4G Nirmal4G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do change the commit message. You don't need to refer individual commits in the message.

Suggested commit message:

Fixed typos in code and comments

@Sergio0694
Copy link
Member

Why would you open a separate PR for the same changes? I just asked to rebase the previous one 🥲
Not to mention this new one is actually worse, as it still has 3 commits and one is a merge commit too.

If you're not familiar with git (or at least, with rebases), I can either take care of this or help guide you through it 🙂

@Sergio0694 Sergio0694 closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirmal4G Nirmal4G Nirmal4G requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbanda @Sergio0694 @Nirmal4G