-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with Windows 11 ListViewStyle #4865
base: main
Are you sure you want to change the base?
Conversation
Issue in WinUI where Windows 11 ListView does not apply alternate row background until hover.
Thanks TyJOrtiz for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@TyJOrtiz please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
@dotnet-policy-service agree |
Any news on this one? I just ran into the same problem and there seems to be a PR available. May someone have a look at it and potentially merge it? |
@TopperDEL Have you tried updating to the 8.x release of the Windows Community Toolkit to see if the issue was resolved? Here's the new repo: https://github.com/CommunityToolkit/Windows |
Thank @niels9001 for the quick response! Yes, I'm already on 8.x but the error is still not solved there. I can see that the changes from this PR are not existent there. So this PR might help in 8.x, too. |
Since the 7.x version is no longer updated, I guess the right tracking issue is: CommunityToolkit/Windows#327 |
Issue in WinUI where Windows 11 ListView does not apply alternate row background until hover.
Fixes
Fixes issue CommunityToolkit/Windows#327
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Windows 11 (possibly 10 too) with WinUI ListView does not apply ListViewExtensions Alternate Row color until mouse hover.
What is the new behavior?
code change finds the content border of the WinUI listview item control template and changes the color when loaded.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information