Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WASDK 1.6.241114003 and CsWinRT 2.1.6 to fix issues with StaggeredLayout in WinUI 3 #232

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

michael-hawker
Copy link
Member

We were hitting issues with ItemSource setting in WinUI 3, per similar notes in CommunityToolkit/Windows#516 Updating CsWin32 provided better error messages (mostly to do with using {Binding} still in samples), but this appears to resolve the ItemsSource issue I was seeing before trying to debug CommunityToolkit/Windows#542

With this change, at least on my x64 machine the StaggeredLayout appears to work again for WinUI 3.

@michael-hawker
Copy link
Member Author

@Arlodotexe you see anything like this before?

"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\CiTestExp.sln" (default target) (1:2) ->
"D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj" (default target) (5:6) ->
(ResolveBuildCompressedStaticWebAssetsConfiguration target) -> 
  C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018: The "ResolveCompressedAssets" task failed unexpectedly. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018: System.InvalidOperationException: Fingerprint for 'D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\bin\Release\net8.0\dist\service-worker.js' is not defined. [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAsset.Validate() [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at Microsoft.AspNetCore.StaticWebAssets.Tasks.StaticWebAsset.FromTaskItem(ITaskItem item) [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at System.Linq.Enumerable.WhereSelectArrayIterator`2.MoveNext() [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at System.Linq.Buffer`1..ctor(IEnumerable`1 source) [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source) [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at Microsoft.AspNetCore.StaticWebAssets.Tasks.ResolveCompressedAssets.Execute() [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]
C:\Program Files\dotnet\sdk\9.0.100\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.Compression.targets(280,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [D:\a\Tooling-Windows-Submodule\Tooling-Windows-Submodule\components\CiTestExp\heads\Wasm\CiTestExp.Wasm.csproj]

@michael-hawker
Copy link
Member Author

Not sure why this is failing for WASM... it appears to be working on main: https://github.com/CommunityToolkit/Windows/actions/runs/12058687686/job/33625899563?pr=572

I'll try running it again to be sure (and fix a typo)

@Arlodotexe
Copy link
Member

Not sure why this is failing for WASM... it appears to be working on main: https://github.com/CommunityToolkit/Windows/actions/runs/12058687686/job/33625899563?pr=572

I'll try running it again to be sure (and fix a typo)

Looks like the tooling submodule still needs the equivalent of https://github.com/CommunityToolkit/Windows/pull/567/files, I'll get this in.

@Arlodotexe
Copy link
Member

Opened #233, this should fix it

…eredLayout in WinUI 3

We were hitting issues with ItemSource setting in WinUI 3, per similar notes in CommunityToolkit/Windows#516
Updating CsWin32 provided better error messages (mostly to do with using {Binding} still in samples), but this appears to resolve the ItemsSource issue I was seeing before
michael-hawker added a commit to CommunityToolkit/Windows that referenced this pull request Dec 2, 2024
@michael-hawker
Copy link
Member Author

Thanks @Arlodotexe, this looks good here now, I've updated/rekicked the Windows version of this PR to test that there too: CommunityToolkit/Windows#572

@michael-hawker
Copy link
Member Author

@Arlodotexe CI passed in Windows repo now, so I think we're good to approve/merge this one?

@Arlodotexe Arlodotexe merged commit eccfbc8 into main Dec 3, 2024
8 checks passed
@Arlodotexe Arlodotexe deleted the llama/update-cswinrt branch December 3, 2024 17:06
michael-hawker added a commit to CommunityToolkit/Windows that referenced this pull request Dec 3, 2024
michael-hawker added a commit to CommunityToolkit/Windows that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants