-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WASDK 1.6.241114003 and CsWinRT 2.1.6 to fix issues with StaggeredLayout in WinUI 3 #232
Conversation
Test commmit for CommunityToolkit/Tooling-Windows-Submodule#232
@Arlodotexe you see anything like this before?
|
Not sure why this is failing for WASM... it appears to be working on main: https://github.com/CommunityToolkit/Windows/actions/runs/12058687686/job/33625899563?pr=572 I'll try running it again to be sure (and fix a typo) |
Looks like the tooling submodule still needs the equivalent of https://github.com/CommunityToolkit/Windows/pull/567/files, I'll get this in. |
Opened #233, this should fix it |
…eredLayout in WinUI 3 We were hitting issues with ItemSource setting in WinUI 3, per similar notes in CommunityToolkit/Windows#516 Updating CsWin32 provided better error messages (mostly to do with using {Binding} still in samples), but this appears to resolve the ItemsSource issue I was seeing before
559fd1a
to
5587991
Compare
Test commmit for CommunityToolkit/Tooling-Windows-Submodule#232
Thanks @Arlodotexe, this looks good here now, I've updated/rekicked the Windows version of this PR to test that there too: CommunityToolkit/Windows#572 |
@Arlodotexe CI passed in Windows repo now, so I think we're good to approve/merge this one? |
Follow-on commmit for CommunityToolkit/Tooling-Windows-Submodule#232
Follow-on commmit for CommunityToolkit/Tooling-Windows-Submodule#232
We were hitting issues with ItemSource setting in WinUI 3, per similar notes in CommunityToolkit/Windows#516 Updating CsWin32 provided better error messages (mostly to do with using
{Binding}
still in samples), but this appears to resolve the ItemsSource issue I was seeing before trying to debug CommunityToolkit/Windows#542With this change, at least on my x64 machine the StaggeredLayout appears to work again for WinUI 3.