Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declared SupportedOSPlatformVersion for WinAppSdk #206

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Aug 20, 2024

Background

For net5.0+ targets, TargetPlatformMinVersion was renamed to SupportedOSPlatformVersion. See dotnet/designs#157

The dotnet SDK uses the TargetPlatformVersion property to provide a default SupportedOSPlatformVersion value if none is explicitly provided. See https://github.com/dotnet/designs/blob/bba3216250cb29b0063bac3ebb57a542ee21ad4f/accepted/2020/minimum-os-version/minimum-os-version.md?plain=1#L73C27-L73C48.

Overview

  • Declares SupportedOSPlatformVersion, using the existing TargetPlatformMinVersion value.
  • Fixes an issue where apps using the toolkit were no longer able to run on versions lower than 19041 (see here).
    • After spinning up VMs for Windows 10 Version 1809 Build 17763 and Windows 10 Version 21H1 Build 19043 to test the RC packages, I'm not seeing any issues building and deploying in a blank WinUI 3 app.

@Arlodotexe
Copy link
Member Author

@michael-hawker do we still want to merge this for posterity?

@michael-hawker michael-hawker merged commit fa8da8f into main Aug 22, 2024
8 checks passed
@michael-hawker michael-hawker deleted the supportedosplatformversion branch August 22, 2024 19:54
@Sergio0694
Copy link
Member

Why did you add this? It shouldn't be needed at all, the .NET SDK is already setting it:

image

This is in Microsoft.NET.Windows.targets. You should just set TargetPlatformMinVersion.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Aug 23, 2024

Why did you add this? It shouldn't be needed at all, the .NET SDK is already setting it:

For posterity, to avoid this kind of confusion in the future.

@Sergio0694
Copy link
Member

But that confirms what I'm saying: you can just set TargetPlatformMinVersion instead, no?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Aug 23, 2024

We did, but the fact that it changed caused the confusion to start with. Docs don't specify anywhere that it's optional if TargetPlatformMinVersion is set, so we wasted time testing something that ended up being a user-side issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants