-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finished MultiTarget support for solution generation #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reference generation
michael-hawker
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, looks like some comment/help text got changed with a find/replace, so should just review that at least. Thanks!
ProjectHeads/AllComponents/Tests.Wasdk/CommunityToolkit.Tests.Wasdk.csproj
Outdated
Show resolved
Hide resolved
michael-hawker
approved these changes
Jul 31, 2024
Arlodotexe
added a commit
to CommunityToolkit/Labs-Windows
that referenced
this pull request
Aug 1, 2024
Arlodotexe
added a commit
to CommunityToolkit/Labs-Windows
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages prior improvements to tooling made in #169 to finish fleshing out MultiTarget support for our generated solution:
MultiTargets
parameter instead ofIncludeHeads
, fully aligned with the rest of our existing system.MultiTargets
provided.GenerateAllProjectReferences.ps1
,GenerateMultiTargetAwareProjectReferenceProps.ps1
andUseTargetFrameworks.ps1
scripts required to support the above changes and a multitarget CI matrixMultiTarget
s, in addition to the existing multitarget-aware conditional project references. This prevents a head from referencing a component that doesn't support the head's TFM or has that multitarget disabled.MultiTargets
it, preventing errors about an empty sample registry.ExcludeMultiTargets
property is now used in all our tooling scripts, not just those introduced in Add new build scripts, minor cleanup #169. (no moreall-uwp
!). Required to support a multitarget CI matrix.Components
parameter can be provided, and only the specified components will be included in the generated solution.WinUIMajorVersion
(aliased towinui
) parameter can be provided and is applied automatically. This is for switching between Uno/WinUI 2 and Uno/WinUI 3 under the same TFM and will be important if UWP and Wasdk ever use the same TFM, but is otherwise a nice-to-have for toolkit developers.We're considering what it would take to move our tooling into reusable packages in the future, and the improvements in this PR touch on alignment and standardization that is necessary for the kind of stable long-term setup we want for our tooling in any reuseable third-party context, whether as a submodule or a set of packages. Other potential high-value tooling improvements that play off the changes here will be fleshed out and filed in a future GitHub issue.