Skip to content

Commit

Permalink
Build-Toolkit-Components.ps1 to not require PreviewVersion parameter (#…
Browse files Browse the repository at this point in the history
…207)

* Build-Toolkit-Components.ps1 to not require PreviewVersion parameter

This is blocking release where we don't have a PreviewVersion postfix to our build number.

* Build-Toolkit-Components.ps1 ensure we don't add Postfix flag when not provided to msbuild

* Revert "Build-Toolkit-Components.ps1 ensure we don't add Postfix flag when not provided to msbuild"

This reverts commit ba0e00a.
  • Loading branch information
michael-hawker authored Aug 21, 2024
1 parent 7d5d479 commit 028fe9c
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions Build-Toolkit-Components.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Specifies the date for versioning in 'YYMMDD' format. The default value is the current date.
.PARAMETER PreviewVersion
Specifies the preview version to use if packaging is enabled. Appended with a dash after the version number (formatted Version-PreviewVersion). This parameter is required when NupkgOutput is supplied.
Specifies the preview version to use if packaging is enabled. Appended with a dash after the version number (formatted Version-PreviewVersion). This parameter is optional.
.PARAMETER NupkgOutput
Specifies the output directory for .nupkg files. This parameter is optional. When supplied, the components will also be packed and nupkg files will be output to the specified directory.
Expand Down Expand Up @@ -114,11 +114,6 @@ if ($ExcludeComponents) {
$Components = $Components | Where-Object { $_ -notin $ExcludeComponents }
}

# Check if NupkgOutput is supplied without PreviewVersion
if ($NupkgOutput -and -not $PreviewVersion) {
throw "PreviewVersion is required when NupkgOutput is supplied."
}

# Use the specified MultiTarget TFM and WinUI version
& $PSScriptRoot\MultiTarget\UseTargetFrameworks.ps1 $MultiTargets
& $PSScriptRoot\MultiTarget\UseUnoWinUI.ps1 $WinUIMajorVersion
Expand Down

0 comments on commit 028fe9c

Please sign in to comment.