-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for net9.0 #55
Conversation
Aside from some CI changes here this is pretty much ready to go when GA is out, going to add some folks for review |
Curious: does this PR require objective sharpie still? Or is that transmogrified part of dotnet9? |
As part of the changes for .NET 9, objective sharpie has become a manual step that you can integrate into your build process as needed. More information about this change can be found in the corresponding docs PR here https://github.com/MicrosoftDocs/CommunityToolkit/pull/487/files |
This PR is useful - but I will use the issue thread to get the correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
question: sharpie generates the macios API as "GetStringWithString" - previously, it would just generate it as "GetString" though (so there was no need to manually change what was generated to match). just curious if you have any idea why we didn't have to before?
I don't think anything here with respect to sharpie output should have changed, but we have manually touched up most of the ApiDefinition files that are included in this repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Context: dotnet/android@dbdc5fa
Context: xamarin/xamarin-macios@4489999
Updates samples and template to target net9.0, using the new
@(AndroidGradleProject)
and@(XcodeProject)
buildactions added to the .NET MAUI SDKs.
The
CommunityToolkit.Maui.NativeLibraryInterop.BuildTasks
projecthas been removed as it is no longer relevant for net9.0.