Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for net9.0 #55

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Updates for net9.0 #55

merged 10 commits into from
Dec 18, 2024

Conversation

pjcollins
Copy link
Collaborator

@pjcollins pjcollins commented Oct 18, 2024

Context: dotnet/android@dbdc5fa
Context: xamarin/xamarin-macios@4489999

Updates samples and template to target net9.0, using the new
@(AndroidGradleProject) and @(XcodeProject) build
actions added to the .NET MAUI SDKs.

The CommunityToolkit.Maui.NativeLibraryInterop.BuildTasks project
has been removed as it is no longer relevant for net9.0.

@pjcollins
Copy link
Collaborator Author

Aside from some CI changes here this is pretty much ready to go when GA is out, going to add some folks for review

@pjcollins pjcollins marked this pull request as ready for review November 14, 2024 22:16
@Peru-S
Copy link

Peru-S commented Nov 20, 2024

Curious: does this PR require objective sharpie still? Or is that transmogrified part of dotnet9?

@pjcollins
Copy link
Collaborator Author

Curious: does this PR require objective sharpie still? Or is that transmogrified part of dotnet9?

As part of the changes for .NET 9, objective sharpie has become a manual step that you can integrate into your build process as needed. More information about this change can be found in the corresponding docs PR here https://github.com/MicrosoftDocs/CommunityToolkit/pull/487/files

@Peru-S
Copy link

Peru-S commented Nov 21, 2024

This PR is useful - but I will use the issue thread to get the correct sharpie bind magic command instead to not conflate this PR thread any more.
Thank you @pjcollins .

Copy link
Collaborator

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

question: sharpie generates the macios API as "GetStringWithString" - previously, it would just generate it as "GetString" though (so there was no need to manually change what was generated to match). just curious if you have any idea why we didn't have to before?

@pjcollins
Copy link
Collaborator Author

LGTM!!!

question: sharpie generates the macios API as "GetStringWithString" - previously, it would just generate it as "GetString" though (so there was no need to manually change what was generated to match). just curious if you have any idea why we didn't have to before?

I don't think anything here with respect to sharpie output should have changed, but we have manually touched up most of the ApiDefinition files that are included in this repo

Copy link
Collaborator

@mikeparker104 mikeparker104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@pjcollins pjcollins merged commit e91dadd into main Dec 18, 2024
3 checks passed
@pjcollins pjcollins deleted the net9 branch December 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants