-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Cake build system to newer version, and updated source to net7.0. #530
Conversation
e63c358
to
45f1264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change!
I think we can release it as Lottie 8.0 if it is a breaking change, especially that it fixes quite a big issue. |
Thanks! |
I think if we're only updating dependencies we don't have to do a major version bump, as per the paragraph in SemVer here:
Upping to 8.0 could get confusing with all the package identity and namespace unification stuff we're doing for the rest of the WCT. |
I see, ok. We did namespace migration for lottie as well, so I think it aligns with it anyway |
Oh, are both UWP and WinUI 3 packages using the same namespace now? Our current thinking and setup is described here where we have two separate packages but a common namespace to aid in transitioning between UWP and WinUI 3 or building components that work on both from the same codebase (without needing forks). We've been discussing if we move to '8.0' or switch to a more date-based schema per package as well. Right now we're just shipping things on our DevOps feeds as we continue to port things, so we have room to change decisions before we push to NuGet. I'll be posting more info on this in the next day or so and can share that for more background on where we've been at with the rest of the WCT. |
This also fixes #478, as this makes sure we are shipping the MSIL version of CommunityToolkit.WinUI.Lottie, which works on all archs (x86, x64, and ARM64).
Only thing that I believe should be discussed here is the versioning. This is a breaking change only due to the bump in support for net7.0, and WAS 1.3.