Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Cake build system to newer version, and updated source to net7.0. #530

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Apr 17, 2023

This also fixes #478, as this makes sure we are shipping the MSIL version of CommunityToolkit.WinUI.Lottie, which works on all archs (x86, x64, and ARM64).
Only thing that I believe should be discussed here is the versioning. This is a breaking change only due to the bump in support for net7.0, and WAS 1.3.

@azchohfi azchohfi force-pushed the alzollin/fixesAndUpgrades branch from e63c358 to 45f1264 Compare April 17, 2023 21:13
@azchohfi azchohfi mentioned this pull request Apr 17, 2023
@azchohfi azchohfi requested a review from aborziak-ms April 17, 2023 22:50
Copy link
Collaborator

@aborziak-ms aborziak-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

@aborziak-ms
Copy link
Collaborator

Only thing that I believe should be discussed here is the versioning. This is a breaking change only due to the bump in support for net7.0, and WAS 1.3.

I think we can release it as Lottie 8.0 if it is a breaking change, especially that it fixes quite a big issue.

@Soap-141
Copy link

Thanks!

@aborziak-ms aborziak-ms merged commit 9c5168a into main Apr 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the alzollin/fixesAndUpgrades branch April 19, 2023 05:59
@michael-hawker
Copy link
Member

I think if we're only updating dependencies we don't have to do a major version bump, as per the paragraph in SemVer here:

What should I do if I update my own dependencies without changing the public API?
That would be considered compatible since it does not affect the public API. Software that explicitly depends on the same dependencies as your package should have their own dependency specifications and the author will notice any conflicts. Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality. We would usually expect additional code for the latter instance, in which case it’s obviously a minor level increment.

Upping to 8.0 could get confusing with all the package identity and namespace unification stuff we're doing for the rest of the WCT.

@aborziak-ms
Copy link
Collaborator

I see, ok. We did namespace migration for lottie as well, so I think it aligns with it anyway

@michael-hawker
Copy link
Member

I see, ok. We did namespace migration for lottie as well, so I think it aligns with it anyway

Oh, are both UWP and WinUI 3 packages using the same namespace now? Our current thinking and setup is described here where we have two separate packages but a common namespace to aid in transitioning between UWP and WinUI 3 or building components that work on both from the same codebase (without needing forks).

We've been discussing if we move to '8.0' or switch to a more date-based schema per package as well. Right now we're just shipping things on our DevOps feeds as we continue to port things, so we have room to change decisions before we push to NuGet. I'll be posting more info on this in the next day or so and can share that for more background on where we've been at with the rest of the WCT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WinUI3 support
4 participants