Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial GraphPresenter prototype for #17 #18

Merged
merged 24 commits into from
Aug 11, 2020

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Oct 21, 2019

Fixes #17
Fixes #27

Pushed some things needed here to the Toolkit in CommunityToolkit/WindowsCommunityToolkit#3033, will update this once those get merged in.

'Done':

TODO/Questions:

  • Test: Make sure getting the right number of days in CalendarView sample
  • Clean-up HTML output in Teams message sample
  • Move FileSize Converter to Toolkit? (not worry about for now, can do later)
  • Remove use of NotifyTaskCompletion (is that sample only use?) Done and added work-around to [Sample] Show using OneDrive Recent Files in GraphPresenter #55

@michael-hawker
Copy link
Member Author

Need to fix StyleCop issues:

         Extensions\GraphExtensions.cs(183,1): error SA1137: Elements should have the same indentation [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(181,47): error SA1629: Documentation text should end with a period [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(182,38): error SA1629: Documentation text should end with a period [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(154,32): error SA1139: Use literal suffix notation instead of casting [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(158,40): error SA1139: Use literal suffix notation instead of casting [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(162,40): error SA1139: Use literal suffix notation instead of casting [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(166,40): error SA1139: Use literal suffix notation instead of casting [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(170,40): error SA1139: Use literal suffix notation instead of casting [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]
         Extensions\GraphExtensions.cs(174,40): error SA1139: Use literal suffix notation instead of casting [D:\a\1\s\Microsoft.Toolkit.Graph\Microsoft.Toolkit.Graph.csproj]

@HerrickSpencer HerrickSpencer changed the base branch from master to main July 10, 2020 18:43
@michael-hawker
Copy link
Member Author

         Converters\FileSizeConverter.cs(11,18): error CS1591: Missing XML comment for publicly visible type or member 'FileSizeConverter' [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj]
         Converters\FileSizeConverter.cs(13,23): error CS1591: Missing XML comment for publicly visible type or member 'FileSizeConverter.Convert(object, Type, object, string)' [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj]
         Converters\FileSizeConverter.cs(23,23): error CS1591: Missing XML comment for publicly visible type or member 'FileSizeConverter.ConvertBack(object, Type, object, string)' [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj]
         Providers\NotifyTaskCompletion.cs(141,45): error SA1502: Element should not be on a single line [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj]
         Providers\NotifyTaskCompletion.cs(109,36): error SA1502: Element should not be on a single line [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj

@michael-hawker michael-hawker marked this pull request as ready for review August 6, 2020 19:34
@michael-hawker michael-hawker added this to the Initial Release milestone Aug 6, 2020
@michael-hawker michael-hawker added the enhancement ✨ New feature or request label Aug 6, 2020
(they need re-work see #55)
Also updated Teams sample messages to remove HTML tags for now.
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😄

Just left a few suggestions and a couple questions!

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@michael-hawker
Copy link
Member Author

@azchohfi thanks for the review, addressed your comments as well and opened #56 for tracking. If it looks good, please merge this.

Also added #57 for updating to our new 7.0.0-preview2 package and the Target SDK bump. If you have a chance to do that update today, that'd be big help for UnoConf. Then we could update our preview package for this as well to align with 7.0.0-preview2.

Thanks! 🦙❤

@azchohfi
Copy link
Collaborator

Working on it!
Small issue!

         Controls\GraphPresenter\QueryOption.cs(28,57): error SA1629: Documentation text should end with a period [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj]

@azchohfi azchohfi merged commit 25be48a into main Aug 11, 2020
@azchohfi azchohfi deleted the michael-hawker/graph-presenter branch August 11, 2020 19:09
@shweaver-MSFT shweaver-MSFT removed this from the 7.0.0 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants