-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Defining DacPac deployment options in SqlDatabaseProjects. #286
Add support for Defining DacPac deployment options in SqlDatabaseProjects. #286
Conversation
@dotnet-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntactically, this looks all good but I'll defer to @jmezach as a SME on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronpowell Just out of curiosity, but did the PublicAPI.Shipped.txt file get automagically updated when we released 9.0? I don't remember doing this, but it must have happened somewhere so I'm just curious how that works exactly ;)
src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/DacpacDeployer.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/ConfigureDacDeployOptionsAnnotation.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aaronpowell I'm not sure what the process is once the PR is approved. |
Needed to be open for merging 😉 Would you be able to update the docs too @nnitkasw? The repo for that is here: https://github.com/dotnet/docs-aspire |
Documentation for new WithConfigureDacDeployOptions extension. Related to issue CommunityToolkit/Aspire#282 and PR CommunityToolkit/Aspire#286
* Update hosting-sql-database-projects.md Documentation for new WithConfigureDacDeployOptions extension. Related to issue CommunityToolkit/Aspire#282 and PR CommunityToolkit/Aspire#286 * Apply suggestions from code review --------- Co-authored-by: David Pine <[email protected]>
This should allow specifying dacpac deployment options.
Closes #282
PR Checklist
Other information
Public members added to the unshipped api documentation.
Includes tests for when options are used and not used.
The readme was updated with an eaxmple of the usage.
This my first contribution on github. I welcome feedback.