Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Defining DacPac deployment options in SqlDatabaseProjects. #286

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

nnitkasw
Copy link
Contributor

This should allow specifying dacpac deployment options.

Closes #282

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Public members added to the unshipped api documentation.
Includes tests for when options are used and not used.
The readme was updated with an eaxmple of the usage.

This my first contribution on github. I welcome feedback.

@nnitkasw
Copy link
Contributor Author

@dotnet-policy-service agree

@nnitkasw nnitkasw changed the title Add support for Defining DacPac deployment in SqlDatabaseProjects. Add support for Defining DacPac deployment options in SqlDatabaseProjects. Nov 25, 2024
Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntactically, this looks all good but I'll defer to @jmezach as a SME on it

@aaronpowell aaronpowell requested a review from jmezach November 25, 2024 22:24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronpowell Just out of curiosity, but did the PublicAPI.Shipped.txt file get automagically updated when we released 9.0? I don't remember doing this, but it must have happened somewhere so I'm just curious how that works exactly ;)

Copy link
Contributor

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nnitkasw
Copy link
Contributor Author

nnitkasw commented Nov 28, 2024

@aaronpowell I'm not sure what the process is once the PR is approved.
But I'm closing the PR to complete it, and will then wait for a merge by your or another owner.
Let me know if it needs to be reopened for it to be merged.

@nnitkasw nnitkasw closed this Nov 28, 2024
@aaronpowell aaronpowell reopened this Nov 29, 2024
@aaronpowell aaronpowell merged commit dd34778 into CommunityToolkit:main Nov 29, 2024
8 checks passed
@aaronpowell
Copy link
Member

@aaronpowell I'm not sure what the process is once the PR is approved. But I'm closing the PR to complete it, and will then wait for a merge by your or another owner. Let me know if it needs to be reopened for it to be merged.

Needed to be open for merging 😉

Would you be able to update the docs too @nnitkasw? The repo for that is here: https://github.com/dotnet/docs-aspire

nnitkasw added a commit to nnitkasw/docs-aspire that referenced this pull request Nov 29, 2024
Documentation for new WithConfigureDacDeployOptions extension. Related to issue CommunityToolkit/Aspire#282 and PR CommunityToolkit/Aspire#286
IEvangelist added a commit to dotnet/docs-aspire that referenced this pull request Dec 2, 2024
* Update hosting-sql-database-projects.md

Documentation for new WithConfigureDacDeployOptions extension. Related to issue CommunityToolkit/Aspire#282 and PR CommunityToolkit/Aspire#286

* Apply suggestions from code review

---------

Co-authored-by: David Pine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow setting DacDeployOptions in DacpacDeployer when publishing SqlServer porjects from dacpac
3 participants