Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement hosted UI #147

Merged
merged 1 commit into from
Jan 12, 2024
Merged

implement hosted UI #147

merged 1 commit into from
Jan 12, 2024

Conversation

hjmodi
Copy link
Contributor

@hjmodi hjmodi commented Jan 10, 2024

No description provided.

@hjmodi hjmodi force-pushed the dev branch 2 times, most recently from 521772e to a0a3a66 Compare January 11, 2024 02:23
@hjmodi hjmodi marked this pull request as ready for review January 11, 2024 02:23
@hjmodi hjmodi requested a review from ligangty January 11, 2024 02:23
ligangty
ligangty reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the StoreListingWidget, please see comments
For the HostedList page, it looks good.
And if possible, the unit test can be added for that HostedList component. Please refer the RemoteList.test.jsx

src/main/webui/src/app/components/content/common/StoreListingWidget.jsx Outdated Show resolved Hide resolved
src/main/webui/src/app/components/content/common/StoreListingWidget.jsx Outdated Show resolved Hide resolved
@hjmodi
implement hosted UI
6a7a579 
Signed-off-by: Harsh Modi <[email protected]>
@hjmodi
Copy link
Contributor Author

hjmodi commented Jan 11, 2024

For the StoreListingWidget, please see comments For the HostedList page, it looks good. And if possible, the unit test can be added for that HostedList component. Please refer the RemoteList.test.jsx

added test

@hjmodi hjmodi requested a review from ligangty January 11, 2024 15:09
ligangty
ligangty approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hjmodi hjmodi merged commit 30074b8 into Commonjava:main Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligangty ligangty ligangty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjmodi @ligangty