Skip to content

Commit

Permalink
Merge pull request #67 from ligangty/2.0-refactor
Browse files Browse the repository at this point in the history
Update lint rules: disable max-line limit
  • Loading branch information
ligangty authored Nov 13, 2023
2 parents ade6117 + 8bd223b commit 7c7d475
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/main/webui/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
"max-classes-per-file": 2,
"max-depth": 2,
"max-len": 0,
"max-lines": 1,
"max-lines": 0,
"max-lines-per-function": 0,
"max-nested-callbacks": 2,
"max-params": 0,
Expand Down
5 changes: 3 additions & 2 deletions src/main/webui/src/app/components/Filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/

export const Filters = {
checkmark(input){
return input ? '\u2713' : '\u2718';
// Return the checkmark icon based on input
checkmark(isChecked){
return isChecked ? '\u2713' : '\u2718';
}
};
1 change: 0 additions & 1 deletion src/main/webui/src/app/components/content/Hints.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ const PasswordMask = ()=> <span className="password-mask">********</span>;
// timer(..., 0)
// }]
// Not sure what this timeout is doing, will check it later

const DisableTimeoutHint = ({children}) =>{
let suggestion = children ? children:
'Integer time in seconds which is used for repo automatically re-enable when set disable by errors,' +
Expand Down
1 change: 0 additions & 1 deletion src/main/webui/src/app/components/content/RemoteList.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {remoteOptionLegend as options} from "../ComponentConstants.js";
import {Utils} from '../CompUtils.js';
import {StoreListingWidget} from './CommonPageWidget.jsx';
import {jsonRest} from '../../RestClient.js';
import {DisableTimeoutHint} from './Hints.jsx';

const init = (state, setState) => {
useEffect(()=>{
Expand Down
1 change: 0 additions & 1 deletion src/main/webui/src/app/components/content/RemoteView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
* limitations under the License.
*/

/* eslint-disable max-lines */
import React, {useState, useEffect} from 'react';
import {useParams} from 'react-router-dom';
import {PropTypes} from 'prop-types';
Expand Down

0 comments on commit 7c7d475

Please sign in to comment.