Reconnect Cassandra client and reinit session when NoHostAvailableException #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sswguo
reviewed
Oct 21, 2024
| client.init(); | ||
| this.init(); | ||
| } | ||
| trackingRecord = session.execute( bind ); |
There was a problem hiding this comment.
Not sure if the session need to be a new one or not, for example in tracking service cluster.connect() may try to reconnect. But you can test locally if you have the instance for test before.
There was a problem hiding this comment.
Or I see, there is client.init(). so let's have a try.
There was a problem hiding this comment.
@sswguo Yeah, the session refetch will call through this class init method. I've tested locally, it could reconnect immediately after re-startup if relocated db server to a different IP, but still need to validate in the real devel Cluster env, I'll merge this to have a try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer the comments https://issues.redhat.com/browse/MMENG-4231, the workaround solution, and I could try to test on devel to verify.