N°7371 - Remembers the choice done in the popup that appears when saving public and private logs at the same time #636
Conversation
|
Please set a PR title explaining the symptom; not a generic one. |
Yes, as it now looks like this PR introduces that bug.. |
accognet
changed the title
| {operation: 'set_pref', code: sPreferenceCode, value: sPrefValue}, function (data) { | ||
| //do nothing | ||
| }).done(function() { | ||
| oUserPreferences[sPreferenceCode] = sPrefValue; | ||
| }); // Make it persistent |
There was a problem hiding this comment.
Comment is misleading. Making the POST call actually persist the preference, so it doesn't do "nothing" and it's not L221 that persists it (it updates local state).
| if ((GetUserPreference('activity_panel.show_multiple_entries_submit_confirmation',true) === true | ||
| || GetUserPreference('activity_panel.show_multiple_entries_submit_confirmation', true) === "true") | ||
| && (Object.keys(this._GetEntriesFromAllForms()).length > 1)) { |
There was a problem hiding this comment.
This feels messy, if the return type isn't strict maybe you should wrap this in a helper to always return a boolean.
There was a problem hiding this comment.
I need to find what the "real" value is. I did a lot of testing and changed the value to 'true' many times that's why this test doesn't look good.
accognet
force-pushed
the
feature/7371-Alert_saving_public_and_private_log
branch
from
85a8e96 to
a47469e
Compare
|
Careful, rebase of the branch wasn't done correctly, you have 237 commits coming to support/3.2 ! :) |
Internal