Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change detectors description #367

Merged
merged 1 commit into from
Sep 7, 2024
Merged

change detectors description #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions detectors/storage-change-events/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ dylint_linting::impl_late_lint! {
"",
StorageChangeEvents::default(),
{
name: "Storage Changed without Emiting an Event",
long_message: "",
severity: "",
help: "",
vulnerability_class: "",
name: "Storage change event checker",
long_message: "Emiting an event when storage changes is a good practice to make the contracts more transparent and usable to its clients and observers",
severity: "Enhancement",
help: "https://coinfabrik.github.io/scout-soroban/docs/detectors/storage-change-events",
vulnerability_class: "Best Practices",
}
}

Expand Down
10 changes: 5 additions & 5 deletions detectors/token-interface-events/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ dylint_linting::impl_late_lint! {
"",
TokenInterfaceEvents::default(),
{
name: "Storage Changed without Emiting an Event in Token Interface implementations",
long_message: " It can originate a problem when a canonical function does not emit an event expected by the contract's clients.",
severity: "",
help: "",
vulnerability_class: "",
name: "Token Interface events checker",
long_message: "Not emiting the established events breaks compatibility with the token standard and can lead to interoperability problems between the contract and its observers",
severity: "Medium",
help: "https://coinfabrik.github.io/scout-soroban/docs/detectors/token-interface-events",
vulnerability_class: "Standard Compliance",
}
}

Expand Down